Fixes for BWC issues, grammar updating#1235
Merged
mengweieric merged 8 commits intoopensearch-project:2.4from Nov 3, 2022
Merged
Fixes for BWC issues, grammar updating#1235mengweieric merged 8 commits intoopensearch-project:2.4from
mengweieric merged 8 commits intoopensearch-project:2.4from
Conversation
Signed-off-by: Eric Wei <menwe@amazon.com>
Signed-off-by: Eric Wei <menwe@amazon.com>
Signed-off-by: Eric Wei <menwe@amazon.com>
Signed-off-by: Eric Wei <menwe@amazon.com>
Signed-off-by: Eric Wei <menwe@amazon.com>
anirudha
previously approved these changes
Nov 3, 2022
joshuali925
previously approved these changes
Nov 3, 2022
Signed-off-by: Eric Wei <menwe@amazon.com>
mengweieric
dismissed stale reviews from joshuali925 and anirudha
via
1a02b05
anirudha
previously approved these changes
Nov 3, 2022
Codecov Report
@@ Coverage Diff @@
## 2.4 #1235 +/- ##
=============================================
+ Coverage 52.91% 70.35% +17.44%
Complexity 292 292
=============================================
Files 283 42 -241
Lines 9766 2392 -7374
Branches 2284 248 -2036
=============================================
- Hits 5168 1683 -3485
+ Misses 4427 568 -3859
+ Partials 171 141 -30
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Eric Wei <menwe@amazon.com>
anirudha
approved these changes
Nov 3, 2022
joshuali925
approved these changes
Nov 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.